Conversation
SchSeba
force-pushed
the
dra_implementation
branch
2 times, most recently
from
db5d52d to
807fbef
Compare
SchSeba
force-pushed
the
dra_implementation
branch
2 times, most recently
from
513bba2 to
08b17dd
Compare
|
connected to k8snetworkplumbingwg/dra-driver-sriov#7 |
|
Hi @moshe010 can you help a look on this? as you did the initial implementation for DRA |
pkg/draclient/draclient.go
Outdated
| "gopkg.in/k8snetworkplumbingwg/multus-cni.v4/pkg/types" | ||
| ) | ||
|
|
||
| type ClientInterace interface { |
There was a problem hiding this comment.
should this be ClientInterface?
| continue | ||
| } | ||
| logging.Debugf("getDeviceID: found device %s, checking for deviceID attribute", device.Name) | ||
| deviceID, exists := device.Attributes["k8s.cni.cncf.io/deviceID"] |
There was a problem hiding this comment.
the k8s.cni.cncf.io/deviceID attribute is not defined anywhere.
There was a problem hiding this comment.
right I was trying to use the same prefix that multus/cni use before to represent the deviceID that we need.
if you have a better attribute prefix let me know I am fine making the change :)
There was a problem hiding this comment.
My main concern is about the link between the projects. Multus and SR-IOV DRA Driver would work together thanks to this label and the SR-IOV CNI would work thanks to deviceID field injected in the CNI config.
There was a problem hiding this comment.
right I was thinking maybe I can document this one to explain how it should get handled for other dra drivers that would like to have the same functionality
would that be ok and answer your concerned?
SchSeba
force-pushed
the
dra_implementation
branch
from
08b17dd to
1bdfbea
Compare
Migrate Dynamic Resource Allocation (DRA) integration from the alpha v1alpha2 API to the stable v1 API introduced in Kubernetes 1.34. Major changes: - Update RBAC permissions to access resource.k8s.io API resources (resourceclaims, resourceslices) instead of using kubelet API - Replace kubelet-based DRA resource discovery with direct API queries using new draclient package - Update documentation from ResourceClass to DeviceClass terminology - Change resourceName annotation format to <claim-name>/<request-name> - Update examples from NVIDIA-specific to generic SR-IOV usage - Add comprehensive test coverage for DRA integration - Remove CDI-based device handling in favor of k8s.cni.cncf.io/deviceID attributes Technical details: - Add draclient.GetPodResourceMap() call in k8sclient - Remove getDRAResources() from kubeletclient (now queries API directly) - Update to use ResourceClaimTemplate instead of ResourceClaim - Fix protobuf field naming (CDIDevices -> CdiDevices) - Add 6 new test cases for DRA scenarios in k8sclient_test.go This migration enables Multus to work with the stable DRA API and removes dependency on kubelet's PodResources API for DRA resources. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
dra_implementation
branch
from
1bdfbea to
51d97b9
Compare
5 participants
No description provided.